Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README GKE Workload Identity instructions #194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rvandernoort
Copy link

This PR updates the docs of GKE Workload Identity by:

  1. removing the [] brackets from the inappropriate spots according to the google docs
  2. Adding missing step of annotating the k8s serviceaccount to couple it with the gcp serviceaccount.

…and include the last step of annotating the k8s sa

Signed-off-by: Rover van der Noort <[email protected]>
Rover van der Noort added 2 commits September 19, 2024 10:52
…and include the last step of annotating the k8s sa

Signed-off-by: Rover van der Noort <[email protected]>
Signed-off-by: Rover van der Noort <[email protected]>
@rvandernoort
Copy link
Author

@qiuming-best @shubham-pampattiwar could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants